Skip to content

Add nullability annotations to ReaderPost #25039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2025
Merged

Add nullability annotations to ReaderPost #25039

merged 4 commits into from
Dec 1, 2025
+106 −81

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Dec 1, 2025 •
edited
Loading

Description

The nullability annotations are based on the ReaderPost schema in the Core Data model file.

@crazytonyli crazytonyli added this to the 26.6 milestone Dec 1, 2025
@crazytonyli crazytonyli requested review from jkmassel and kean December 1, 2025 01:39
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 1, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30033
VersionPR #25039
Bundle IDorg.wordpress.alpha
Commit38a225e
Installation URL13dc9kbrae458
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30033
VersionPR #25039
Bundle IDcom.jetpack.alpha
Commit38a225e
Installation URL6uqf8vrs7q0b0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

kean
kean reviewed Dec 1, 2025
View reviewed changes
WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailCoordinator.swift Outdated
///
private func showTag() {
guard let post else {
guard let post, let primaryTagSlug = post.primaryTagSlug else {
Copy link
Contributor

@kean kean Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) add wpAssertionFailure

kean
kean approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment.

@crazytonyli crazytonyli enabled auto-merge December 1, 2025 20:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@crazytonyli crazytonyli added this pull request to the merge queue Dec 1, 2025
Merged via the queue into trunk with commit aa4119c Dec 1, 2025
26 of 32 checks passed
@crazytonyli crazytonyli deleted the core-data-models-posts branch December 1, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kean kean kean approved these changes

@jkmassel jkmassel Awaiting requested review from jkmassel

Assignees

No one assigned

Labels

[Type] Tech Debt

Projects

None yet

Milestone

26.6

Development

Successfully merging this pull request may close these issues.

5 participants

@crazytonyli @dangermattic @wpmobilebot @kean